Commit 996f7591 authored by Gerson Sunyé's avatar Gerson Sunyé
Browse files

Commented several rules that raised error when executed with different input models

parent 14ea4dfd
......@@ -37,15 +37,12 @@ helper def: allMeasures(project : java!Model): Set(smm!Measure) =
-- Multithreading rules
--
thisModule.dontCallThreadRun(),
thisModule.avoidThreadGroup(),
thisModule.useNotifyAllInsteadOfNotify(),
-- Code Style rules
--
thisModule.shortMethodName(),
thisModule.tooManyStaticImports(),
thisModule.avoidDollarSigns(),
thisModule.shortClassName(),
thisModule.shortVariableName(),
thisModule.extendsObject(),
......@@ -59,11 +56,9 @@ helper def: allMeasures(project : java!Model): Set(smm!Measure) =
thisModule.returnFromFinallyBlock(),
thisModule.longInstantiation(),
thisModule.shortInstantiation(),
thisModule.returnEmptyArrayRatherThanNull(),
thisModule.excessiveParameterList(),
thisModule.finalFieldCouldBeStatic(),
thisModule.signatureDeclareThrowsException(),
thisModule.avoidThrowingNullPointerException(),
-- Performance rules
--
......@@ -75,12 +70,10 @@ helper def: allMeasures(project : java!Model): Set(smm!Measure) =
thisModule.emptyStatementBlock(),
thisModule.avoidRethrowingException(),
thisModule.integerInstantiation(),
thisModule.UseArrayListInsteadOfVector(),
-- Documentation rules
--
thisModule.commentContent(),
thisModule.commentRequired(),
-- Error prone rules
......@@ -89,29 +82,39 @@ helper def: allMeasures(project : java!Model): Set(smm!Measure) =
thisModule.suspiciousEqualsMethodName(),
thisModule.doNotExtendJavaLangThrowable(),
thisModule.doNotExtendJavaLangError(),
thisModule.compareObjectsWithEquals(),
thisModule.avoidCallingFinalize(),
thisModule.emptyTryBlock(),
thisModule.emptyWhileStmt(),
thisModule.dontImportSun(),
thisModule.emptySwitchStatement(),
thisModule.emptySynchronizedBlock(),
thisModule.emptyFinallyBlock(),
thisModule.emptyfinalizeMethod(),
--thisModule.doNotThrowExceptionInFinally(),
--thisModule.finalizeShouldBeProtected(),
-- Best practices rules
thisModule.avoidThrowingNewInstanceOfSameException(),
thisModule.useAssertTrueInsteadOfAssertEquals(),
thisModule.useAssertSameInsteadOfAssertTrue(),
thisModule.switchDensity()
--thisModule.replaceVectorToList()
--thisModule.unusedPrivateMethod ()
--thisModule.avoidStringBufferField()
-- Bugged rules:
--
-- thisModule.avoidThrowingNullPointerException(),
-- thisModule.UseArrayListInsteadOfVector(),
-- thisModule.commentRequired(),
-- thisModule.compareObjectsWithEquals(),
-- thisModule.emptyWhileStmt(),
-- thisModule.emptyFinallyBlock(),
-- thisModule.emptyfinalizeMethod(),
-- thisModule.doNotThrowExceptionInFinally(),
-- thisModule.finalizeShouldBeProtected(),
-- thisModule.avoidDollarSigns(),
-- thisModule.avoidThreadGroup(),
-- thisModule.dontCallThreadRun(),
-- thisModule.returnEmptyArrayRatherThanNull(),
-- thisModule.replaceVectorToList()
-- thisModule.unusedPrivateMethod ()
-- thisModule.avoidStringBufferField()
-- thisModule.avoidThrowingNewInstanceOfSameException(),
};
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment