Merge branch 'master' into 'master'

Correction finalizeShouldBeProtected #830 See merge request !153

Merge branch 'master' into 'master'
Correction finalizeShouldBeProtected #830 See merge request !153
2f4ad8d5 · Gerson SUNYE · 00a72f53 · 5e8127ff · 2f4ad8d5
Commit 2f4ad8d5 authored Dec 22, 2019 by Gerson SUNYE
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

src/main/atl/errorProne.atl src/main/atl/errorProne.atl +2 -1

No files found.
--- a/src/main/atl/errorProne.atl
+++ b/src/main/atl/errorProne.atl
@@ -177,7 +177,8 @@ helper def: dontImportSun() : Set(smm!Measure) =
 -- Rule for metrics FinalizeShouldBeProtected
 helper def: finalizeShouldBeProtected() : Set(smm!Measure) = 
 	java!MethodDeclaration.allInstances()
-		->select(m | m.name = 'finalize' and m.modifier <> 'protected')
+		->select(m | m.modifier <> OclUndefined)
+		->select(m | m.name = 'finalize' and m.modifier.visibility.toString() <> 'protected')
 		->collect(m | thisModule.MesureFinalizeShouldBeProtected(m));